[Bug ld/23162] assertion fail binutils/bfd/elf32-i386.c:3953

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23162

H.J. Lu <hjl.tools at gmail dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #11002|0 |1
is obsolete| |

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
Comment on attachment 11002
--> https://sourceware.org/bugzilla/attachment.cgi?id=11002
A patch

The patch is posted at

https://sourceware.org/ml/binutils/2018-05/msg00127.html

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23162

H.J. Lu <hjl.tools at gmail dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |hjl.tools at gmail dot com

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 11002
--> https://sourceware.org/bugzilla/attachment.cgi?id=11002&action=edit
A patch

I am testing this.

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23162

H.J. Lu <hjl.tools at gmail dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |nickc at redhat dot com

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23162

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9bc935ef3380a2d471b9447e2bf8e61297654e2f

commit 9bc935ef3380a2d471b9447e2bf8e61297654e2f
Author: H.J. Lu <***@gmail.com>
Date: Mon May 14 03:47:47 2018 -0700

x86: Mark __bss_start, _end and _edata locally defined

__bss_start, _end and _edata are defined by linker to mark regions
within executables and shared libraries. All references within
executables should be locally resolved.

This patch doesn't change how their references within shared libraries
are resolved.

bfd/

PR ld/23162
* elfxx-x86.c (elf_x86_linker_defined): New function.
(_bfd_x86_elf_link_check_relocs): Use it to mark __bss_start,
_end and _edata locally defined within executables.

ld/

PR ld/23162
* testsuite/ld-elf/pr23162.map: New file.
* testsuite/ld-elf/pr23162.rd: Likewise.
* testsuite/ld-elf/pr23162a.c: Likewise.
* testsuite/ld-elf/pr23162b.c: Likewise.
* testsuite/ld-elf/shared.exp: Run PR ld/23162 tests.

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23162

H.J. Lu <hjl.tools at gmail dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |2.31

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for 2.31.